Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade puppeteer to 22.11.1 #16070

Merged
merged 4 commits into from
Jun 18, 2024
Merged

deps: upgrade puppeteer to 22.11.1 #16070

merged 4 commits into from
Jun 18, 2024

Conversation

adamraine
Copy link
Member

@adamraine adamraine commented Jun 12, 2024

https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v22.11.1
https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v22.11.0
https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v22.10.1

There were some type errors that appeared only because we reach into pptr internals for Lightrider entry. I didn't see a way to hack around it so I went with what I think is a better way to handle this situation: just use skipLibCheck in a new tsconfig.json.

This also removes the need for that stupid rxjs.d.ts hack introduced a while back. Nevermind we do need it 🙃

@adamraine adamraine requested a review from a team as a code owner June 12, 2024 18:31
@adamraine adamraine requested review from connorjclark and removed request for a team June 12, 2024 18:31
@adamraine adamraine changed the title deps: upgrade puppeteer to 22.11.0 deps: upgrade puppeteer to 22.11.1 Jun 18, 2024
@adamraine adamraine merged commit 167dc1f into main Jun 18, 2024
26 of 27 checks passed
@adamraine adamraine deleted the pptr_22.11.0 branch June 18, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants